WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 4 years ago

#59 closed defect (fixed)

Plugins search bug

Reported by: mordauk Owned by:
Milestone: Priority: low
Component: Plugin Directory Keywords:
Cc:

Description

This is a little weird.

I searched for "Easy Digital Downloads" and it came up with 17 plugins (3 pages): http://wordpress.org/plugins/search.php?q=easy+digital+downloads&sort=

At the top of page 1 is says "Showing 1-8 of 17 plugins"

Scrolling to the bottom it shows there are 3 pages.

Clicking over to page 2 and then it says "Showing 9-16 of 15 plugins".

Where'd the last 2 of the original 17 go?

Change History (16)

#1 @mordauk
6 years ago

  • Cc pippin@… added

#2 @Otto42
6 years ago

Are you logged in? Try it as a normal, non-empowered user. Incognito window in chrome works fine.

The paging doesn't fully account for magic moderator powers.

#3 @mordauk
6 years ago

Yes, logged in as a moderator on both pages.

#4 follow-up: @Otto42
6 years ago

If it works for the majority of the populace and only looks weird to us, then I'm inclined to wontfix or maybelater it. Checking with a non-admin user will tell that difference.

#5 @mordauk
6 years ago

If I manually change the ?page parameter to 3, then suddenly it shows that there are 24 plugins: http://wordpress.org/plugins/search.php?page=3&q=easy+digital+downloads&sort=

#6 @mordauk
6 years ago

Page 3 shows the same for me both logged in and logged out: http://wordpress.org/plugins/search.php?page=3&q=easy+digital+downloads&sort=

Logged out, page 1 shows Showing 1-8 of 16 plugins, but page 2 shows Showing 9-16 of 14 plugins

#7 @netweb
6 years ago

  • Cc netweb added

Just noticed the same issue for BuddyPress, added bbPress and EDD tabulated results also, tested logged in and with not logged in incognito browser window.

I don't think I have any 'magic moderator powers' on wordpress.org
I do have 'magic moderator powers' (moderator) on bbpress.org

BuddyPress (http://buddypress.org/extend/plugins/ Viewing 1 to 10 (476 total))

LinkResults Count DisplayedPagination Links Displayed
/search.php?q=buddypressShowing 1-8 of 17 plugins1, 2, 3, Next
/search.php?page=2&q=buddypressShowing 9-16 of 16 pluginsPrevious, 1, 2
/search.php?page=3&q=buddypressShowing 17-24 of 16 pluginsPrevious, 1, 2

bbPress (via http://bbpress.org/plugins/ Viewing 1 to 10 (127 total))

LinkResults Count DisplayedPagination Links Displayed
/search.php?q=bbpressShowing 1-8 of 17 plugins1, 2, 3, Next
/search.php?page=2&q=bbpressShowing 9-16 of 16 pluginsPrevious, 1, 2
/search.php?page=3&q=bbpressShowing 17-24 of 16 pluginsPrevious, 1, 2

Easy Digital Downloads

LinkResults Count DisplayedPagination Links Displayed
q=easy+digital+downloadShowing 1-8 of 148 plugins1, 2, ..., 19, Next
q=easy+digital+downloads&sort=popularShowing 1-8 of 148 plugins1, 2, ..., 19, Next
q=easy+digital+downloads&sort=top-ratedShowing 1-8 of 148 plugins1, 2, ..., 19, Next
q=easy+digital+downloads&sort=newShowing 1-8 of 148 plugins1, 2, ..., 19, Next
q=easy+digital+downloads&sort=Showing 1-8 of 16 plugins1, 2, Next

Using sort modifiers &sort=popular, &sort=top-rated or &sort=new all counts work as expected.

Using q=query+term+string or q=query+term+string&sort= counts results are wonky!

#8 in reply to: ↑ 4 @ericlewis
6 years ago

Replying to Otto42:

If it works for the majority of the populace and only looks weird to us, then I'm inclined to wontfix or maybelater it. Checking with a non-admin user will tell that difference.

I am logged out and get the bad results.

This is a pretty major bug, just sayin'.

#9 @Otto42
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Found a bug in the relevance search that caused the wrong maximum to be used for the pagination. Result counts and pagination should be more consistent now, although it is not guaranteed for them to be identical at all times due to delays in the search engine indexing process.

#10 @kovshenin
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Got a report in #wp29791 about broken pagination in plugin search, which turned out to be a WordPress.org-wide issue. Our Sphinx and BB_Query total search results are different, probably because BB also excludes closed topics but Sphinx doesn't. I'll look into adding topic_open to the Sphinx index.

#11 @jenmylo
5 years ago

Adding this because @ocean90 suggests it's related. I did a search for BuddyPress Groupblog. The search results had 4 plugins, but the number said there were 3. The first one hadn't been updated in 5 years and had the same name as the 2nd one, so maybe that was the reason for the discrepancy? But the 5 year old one really shouldn't have been displayed, I thought, since it had been more than 2 years.

#12 @Otto42
5 years ago

The 5 year old one is displayed because it's an exact match on the slug (ignoring spaces). Results older than 2 years are discoverable for exact matches.

The count is still an issue, because of the exact match check. It adds the exact match to the results but doesn't update the count properly. If you search for "buddypress groupblogs" (note the plural), then the exact match isn't there anymore and the count is correct.

#13 @Otto42
5 years ago

Made a patch to correct the total count for that case.

#14 @Otto42
5 years ago

#963 was marked as a duplicate.

This ticket was mentioned in Slack in #meta by sam. View the logs.


4 years ago

#16 @Otto42
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This should be fixed in most places. Any remaining edge cases can wait for a greater revamp.

Note: See TracTickets for help on using tickets.