Making WordPress.org

Opened 15 months ago

Closed 8 months ago

Last modified 8 months ago

#6981 closed defect (bug) (fixed)

Menu position is not correct.

Reported by: rima1889's profile rima1889 Owned by:
Milestone: Priority: normal
Component: Developer Hub Keywords: needs-docs has-screenshots needs-patch needs-testing
Cc:

Description

https://developer.wordpress.org/cli/commands/
The menu position is not correct.
https://tinyurl.com/2qxdfwry

Attachments (2)

Screenshot 2023-05-20 at 1.22.05 PM.png (286.7 KB) - added by naeemhaque 14 months ago.
Fixes after applying css properties
imgonline-com-ua-twotoone-vlDBtLEbe9 (1).jpg (326.0 KB) - added by dhrumilk 13 months ago.

Download all attachments as: .zip

Change History (11)

@naeemhaque
14 months ago

Fixes after applying css properties

#1 follow-up: @naeemhaque
14 months ago

Here is some code for resolving this issue.
I have applied this CSS and it's perfectly working.

.site-branding {
    display: flex;
    justify-content: space-between;
}

After applying the CSS don't need to keep float: right; CSS property in .menu-container and .main-navigation class. So you can remove these two property.

Here is a snapshot to understand

https://meta.trac.wordpress.org/attachment/ticket/6981/Screenshot%202023-05-20%20at%201.22.05%20PM.png

#2 @naeemhaque
14 months ago

#6983 was marked as a duplicate.

#3 @harshgajipara
13 months ago

#7092 was marked as a duplicate.

#4 in reply to: ↑ 1 @dhrumilk
13 months ago

  • Keywords needs-patch needs-testing added
  • Priority changed from low to high
  • Type changed from enhancement to defect (bug)

Replying to naeemhaque: I have applied this one CSS but still, there is an issue in font size so can you update the CSS and also apply the font size same as other.

Here is some code for resolving this issue.
I have applied this CSS and it's perfectly working.

.site-branding {
    display: flex;
    justify-content: space-between;
}

After applying the CSS don't need to keep float: right; CSS property in .menu-container and .main-navigation class. So you can remove these two property.

Here is a snapshot to understand

https://meta.trac.wordpress.org/attachment/ticket/6981/Screenshot%202023-05-20%20at%201.22.05%20PM.png

#6 in reply to: ↑ 5 ; follow-up: @dhrumilk
13 months ago

Replying to dd32: I have verified the PR changes but I have checked there is an issue in the font size. On other pages, the font size is bigger than the commands page. see the below screenshot.

This should be fixed via https://github.com/WordPress/wporg-developer/commit/78f3a3c5a05cc6f1f6dc7bdbae64a084f4a3c29b

#7 in reply to: ↑ 6 @dd32
13 months ago

Replying to dhrumilk:

Replying to dd32: I have verified the PR changes but I have checked there is an issue in the font size. On other pages, the font size is bigger than the commands page. see the below screenshot.

For reference, the comparison page is https://make.wordpress.org/cli/handbook/

Yes, it does appear that the Make theme has a higher base font size, resulting in the menu being larger there.

#8 @coffee2code
8 months ago

  • Component changed from General to Developer Hub
  • Priority changed from high to normal
  • Resolution set to fixed
  • Status changed from new to closed

The last bit of this was implemented in b4c6662 on GitHub:

Improve WP-CLI Commands page menu styling.

Increases font size and spacing.

Props dhrumilk.
Fixes #6981.

#9 @coffee2code
8 months ago

#6736 was marked as a duplicate.

Note: See TracTickets for help on using tickets.