WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1049 closed task (fixed)

Update Rosetta Theme

Reported by: ocean90 Owned by:
Milestone: Priority: normal
Component: International Sites (Rosetta) Keywords:
Cc:

Description (last modified by ocean90)

Related tickets:

Change History (31)

#1 @ocean90
4 years ago

  • Description modified (diff)

#2 @ocean90
4 years ago

In 1615:

Rosetta Theme: Responsive and other improvements.

  • Add template for 404 error.
  • Add template for front page which was previously the index template.
  • Update index template to support static front page and page for posts.
  • Update comments template to use wp_list_comments() and comment_form().
  • Update styling of blog posts.

see #1049.

#3 @ocean90
4 years ago

ToDo:

  • archive.php
  • RTL styles via grunt-rtlcss
  • Front page cleanup
  • <?php _e('<strong>Please, do not post support requests here!</strong> They will probably be ignored.', 'rosetta'); ?> for comments
  • CSS cleanup
  • @sam: We should fix the footer too, so it’s always on the “bottom” of the page, even if the page isn’t very long.
Last edited 4 years ago by ocean90 (previous) (diff)

#4 @ocean90
4 years ago

In 1619:

Rosetta Theme: Update RTL stylesheet.

This is the LTR stylesheet run through grunt-rtlcss.

see #1049.

#5 @ocean90
4 years ago

In 1621:

wp4.css: Use current header menu styling also for .current_page_parent.

see #1049, #671.

#6 @ocean90
4 years ago

In 1622:

Rosetta Theme: Add home.php which is a copy of front-page.php.

This provides backwards compatibility for sites, which don't have a static front page yet.

see #1049.

#7 follow-up: @ramiy
4 years ago

@ocean90, you can close ticket #1047, it's fixed in changeset [1615]

#8 @ocean90
4 years ago

In 1623:

Revert [1622].

Turns out that the template hierarchy works as expected. It was an issue with a wrong show_on_front option for one site.

see #1049.

#9 @ocean90
4 years ago

In 1624:

Rosetta Theme: Responsive and other improvements.

  • Fix missing content on single posts.
  • Update archive template.
  • Update contact page template.
  • Add previous/next post navigation to single posts.
  • Make more link text translatable.

see #1049.

#10 @ocean90
4 years ago

In 1626:

Rosetta Theme: Remove debug remnants.

see #1049.

#11 in reply to: ↑ 7 @ramiy
4 years ago

@ocean90, you can also close ticket #800.

#12 @ramiy
4 years ago

Meta tickets #392, #742, #800, #1036 can be closed, they are all rosetta related.

Last edited 4 years ago by ramiy (previous) (diff)

#13 @ramiy
4 years ago

also, in mobile view there is a problem in style-rt.css

.storycontent {
  padding-left: 60px;
}

It adds a big padding to the left.

In mobile devices it's alot!

By the way, the ltr css has no padding.

#14 @ocean90
4 years ago

In 1627:

wp4-rtl: Reset padding for .storycontent.

see #1049.

#15 @ocean90
4 years ago

In 1629:

Rosetta Theme: Add column wrapper to inactive translations header.

see #1049.

#16 @ocean90
4 years ago

In 1630:

Rosetta Theme: Add comment reply script.

see #1049.

#17 @ocean90
4 years ago

In 1631:

Rosetta Theme: Add a support hint to the comment form.

The string is already used on the contact page.

see #1049.

#18 @ramiy
4 years ago

@ocean90, see ticket #1051, I've added sidebars.

This ticket was mentioned in Slack in #polyglots by ocean90. View the logs.


4 years ago

#20 @adrian.pop
4 years ago

Hi,

I saw the example You mention in the slack conversation http://de.wordpress.org/blog/ and I just tried to create a similar page http://ro.wordpress.org/blog/ but there are no posts displayed on it, exept the sidebar. Should I use some special template or a shortcode?

Thanks.

#21 @ramiy
4 years ago

@ocean90, one more ticket - #1057

#22 follow-up: @ocean90
4 years ago

In 1641:

Rosetta Theme: Enhancements

  • Move sidebar code to its own files.
  • Show blog section on front page only when show_on_front is posts.
  • Add some inline docs.

props ramiy.
fixes #1057, #1051.
see #1049.

#23 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#24 in reply to: ↑ 22 ; follow-ups: @adrian.pop
4 years ago

Replying to ocean90:

so where can we set the 'show_on_front' to 'posts'? I tried to set a custom field "show_on_front" with the value "posts" for the Blog page in ro.wordpress.org but nothing happened :) Looks to me, from your comment bellow, that this is the obvious choice for the "pages" that we want to apear as sections on the Home Page, But apparently my intuition sucks :) So, is there another mechanism, and the editor has access to it?
Right now, the blog section is completly missing from the home page.

In 1641:

Rosetta Theme: Enhancements

  • Move sidebar code to its own files.
  • Show blog section on front page only when show_on_front is posts.
  • Add some inline docs.

props ramiy.
fixes #1057, #1051.
see #1049.

Last edited 4 years ago by adrian.pop (previous) (diff)

#25 in reply to: ↑ 24 ; follow-up: @ramiy
4 years ago

Replying to adrian.pop:

Right now, the blog section is completly missing from the home page.

You Need to:

  1. Create a new page for your blog posts.
  2. Set it to be your "Blog posts page" from Settings->Reading.
  3. Add this page to "Main Menu" from Appearance->Menus.

#26 in reply to: ↑ 25 ; follow-up: @adrian.pop
4 years ago

Replying to ramiy:
1 and 3 were done.
2 - There is no Settings entry in the Dashboard Menu, to set the "Blog posts page".

Replying to adrian.pop:

Right now, the blog section is completly missing from the home page.

You Need to:

  1. Create a new page for your blog posts.
  2. Set it to be your "Blog posts page" from Settings->Reading.
  3. Add this page to "Main Menu" from Appearance->Menus.

#27 in reply to: ↑ 26 @ramiy
4 years ago

Replying to adrian.pop:

There is no Settings entry in the Dashboard Menu, to set the "Blog posts page".

I know, see ticket #1065 (set static front page)

#28 in reply to: ↑ 24 @ocean90
4 years ago

Replying to adrian.pop:

'show_on_front' is the option in wp-admin/options-reading.php (Afișează pe prima pagină). You don't have access to this page. It just means that you blog posts are now on https://ro.wordpress.org/blog/ instead of https://ro.wordpress.org.

#29 follow-up: @adrian.pop
4 years ago

I understand.
But why not use such a custom field (with values of yes/no) to allow pages as Blog, Download, Install, or others to be shown in appropriate sections of the home page?
For bc these pages in existing sites will receive automatically the custom field set, and for future, anyone can set, in a more flexible manner, the home page content, and order of sections based on IDs... - Just an idea :)

In the meantime I would like the blog section to appear at the end of home page, please!

#30 in reply to: ↑ 29 @ocean90
4 years ago

Replying to adrian.pop:

In the meantime I would like the blog section to appear at the end of home page, please!

The blog section will be removed for all sites soon, they won't come back. There is no need to add them to the front page too, Rosetta isn't a one-page site anymore.

#31 @ocean90
4 years ago

In 1783:

Rosetta Theme: Remove margin around share buttons.

see #1049.

Note: See TracTickets for help on using tickets.